Closed thorvindr closed 6 years ago
@thorvindr My guess is incorrect glob. It should be ${title}.sfc
instead of ${title}
.
Yeah, I finally came around to using the simple glob ${title}.sf* , accompanied by the code that is supposed to remove all bracketed text in the filename from the title. In reality, it only removes one instance of parenthetical text and does nothing with brackets. So I no longer have fuzzy falsely-identifying games but I do have several titles a mile long.
Also had to disable fuzzy everything to stop getting false identities.
@thorvindr Could you provide me with a list of all titles (or filenames)? I'm working on next SRM version and I'm rewriting everything. I could use them as test cases.
Closing due to inactivity.
Ach. Sorry I didn't get back sooner. Yes, I can give you some filenames. The most ridiculous one is the one in the title. The file "aladdin (USA).sfc" was named "Star Wars Galaxies Trading Card Game: Champions of the Force." I also have "frogger.sfc" being identified as "Frogger Beyond."
This is very strange :/ I can't replicate this. Could you copy-paste configuration? There's a button for that on the bottom right.
I can't give you that immediately because I'm not using that configuration anymore. It was the default config. I changed nothing and just told it to generate a list. Hang on; I'll see if I can make it do it again.
Alight I've got it doing it again. Not only will I copy my config but I'll give you a screenshot of my parser test as well. Standby.
Working on getting you the config. I'm running the app in a sandbox container so it can't screw up my steam library but that also means the app can't access the clipboard. Working it out.
@thorvindr what glob are you using?
I will verify that this behavior is happening when the "User's glob" field is filled with "${title}" (which is the default entry).
When I change it to "${title}.sf*, it identifies that first file as "Aladdin." But it still leaves bracketed and parenthetical text in the titles (see the Donkey Kong title near the bottom).
I can at least give a screenshot of what seems to be the relevant part of the config screen.
So yeah. Issue as listed definitely solved by better glob. Still seems weird behavior to return a title that's so unrelated to the filename. Sincerely sorry if this has been a waste of your time.
Donkey kong has smc
ending whereas other games have sfc
.
As for unrelated titles, it's due to fuzzy matcher failing to find game in the steamgriddb
list. I can't really fix it as it is technically correct, because the algorithm says so.
Changed the glob to ${title}.s* and here are the results:
The title modifier code that's supposed to remove "all brackets" actually removes no brackets but removes the first instance of parentheses.
For title modifier I recommend trying ${fuzzyTitle}
(it seems to be working right now). However, if you want to preserve your titles, use ${title}
.
Now, to remove (...)
and [...]
from final title (either because fuzzy matcher did not or you are using anything else, but ${fuzzyTitle}
), use /\s?\(.*?\)|\s?\[.*?\]/g
regular expression in title modifier. It will match extra space (\s?
) if it exist and either (...)
and/or [...]
. g
flag allows to match multiple times.
okay thanks. I'll give that a try.
Not sure what that's latching onto to name it that.