Wiped out all my Steam ROM Manager and manually added non-Steam games

SteamGridDB / steamgriddb-manager

Automatically find games from launchers on your system and import them into your Steam library with a click of a button.

https://www.steamgriddb.com/manager

MIT License

397 stars 55 forks source link

Wiped out all my Steam ROM Manager and manually added non-Steam games #77

Open 8BitCerberus opened 4 years ago

8BitCerberus commented 4 years ago

Describe the bug Every game added by Steam ROM Manager and any game I've manually added as a non-Steam game have been wiped out after running SteamGridDB Manager to import some GOG games.

Expected behavior To not affect any manually added non-Steam games, whether from other utilities like Steam ROM Manager, or otherwise.

Operating System

Windows 10, 1909

8BitCerberus commented 4 years ago

I have since tested whether this happens with Steam ROM Manager as well, and it does not wipe out any of my manually added non-Steam games. It seems like SteamGridDB Manager is overwriting the shortcuts.vdf file, instead of appending to it.

harvii commented 4 years ago

This -might- be related to case sensitivity here: https://github.com/SteamGridDB/steamgriddb-manager/blob/320d1a181c8389f343c6148ea9fe2a6ef965b054/src/js/Steam.js#L354

Editing shortcuts.vdf manually and changing all existing 'AppName' and 'Exe' to lowercase preserved the existing entries.

aranel616 commented 3 years ago

In my shortcuts.vdf file, all existing appname and exe entries are already lowercase, including games I imported outside of the manager.

aranel616 commented 3 years ago

When I started investigating this issue, importing a game was deleting existing non-steam games that were not imported by the manager. At some point during my debugging, the bug stopped reproducing for me. I'm not sure why.

In any case, it seems to be related to a dupe check in addShortcuts.