search

SteamLUG / steamlug.org

SteamLUG
https://steamlug.org
9 stars 11 forks source link

Revert new Steam sign-in button (#199) #207

Closed her001 closed 7 years ago

her001 commented 7 years ago

This reverts commits 1b6341efe20d47f35ef838178ef32f433500b5c9, 4ba5cbfef0626cfd37376e65d4713fa541411747, and 8ce01235b48bbb8d37221e36487cbe589c148ab2.

These are the two commits from the pull request and the one related CSS tweak that was made afterward.

her001 commented 7 years ago

I don't like this. We are reverting something that was sitting for a long time without comment, with many requests for review, then merged before it was disputed. To have it reverted now is like a big "don't ever contribute to us" sign, in my opinion.

But if people care enough, then this can be accepted.

For more background, see #199. Basically, the PR sat for 9 months without comment. Eventually some constructive criticism was provided, which was acted upon, then it was merged. It was only after the merge happened that disputes were raised over the aesthetic change that the PR brought. Basically, the new Steam sign-in button, which Valve requests that people use, is ugly. Everyone was either okay with it or didn't care to comment until after.

her001 commented 7 years ago

This has gone a day without comment. If anyone wants it badly enough, they can reopen it.

Corben78 commented 7 years ago

Give people some time!

johndrinkwater commented 7 years ago

I may have time on Saturday, apologies if that is not soon enough.

her001 commented 7 years ago

While I closed this a day after I opened it, and normally I wouldn't consider that to be enough time, the PR we would be reverting sat for over 9 months. I also kept asking for people to review our open PRs. You had time to respond.

And, as I said, you can reopen it. Which you have.