her001
commented
7 years ago My comment on #207:
I don't like this. We are reverting something that was sitting for a long time without comment, with many requests for review, then merged before it was disputed. To have it reverted now is like a big "don't ever contribute to us" sign, in my opinion.
But if people care enough, then this can be accepted.
For more background, see #199. Basically, the PR sat for 9 months without comment. Eventually some constructive criticism was provided, which was acted upon, then it was merged. It was only after the merge happened that disputes were raised over the aesthetic change that the PR brought. Basically, the new Steam sign-in button, which Valve requests that people use, is ugly. Everyone was either okay with it or didn't care to comment until after.
johndrinkwater
This reverts commit a8d4c19201d1e6216b9872ca92ad006fa564a802.
The commit message states:
Sorry, but I do not agree that "we" came to this conclusion. Two people (@meklu and me) in the steamlug.org group were okay with it, while two others (@johndrinkwater and @Corben78) disputed it after it sat for 9 months and was merged. Nobody else had any comments on the matter. There was no conclusion.
I think it is unfair for @johndrinkwater to decide to make the change without further conversation, which #207 was made to facilitate. As @johndrinkwater has made clear to me before, it is important that people don't just commit to this repo at will, with no review beforehand.