SteamLUG / steamlug.org

SteamLUG
https://steamlug.org
9 stars 11 forks source link

Tree View for Mumble page #39

Closed swordfischer closed 9 years ago

swordfischer commented 11 years ago

A http://experiments.wemakesites.net/css3-treeview.html like view for the in-progress mumble page.

/var/www/dev.steamlug.org/swordfischer_mumble/mumble.php

swordfischer commented 11 years ago

I will merge this later unless someone has any objections?

Cheeseness commented 11 years ago

Did you end up making an expanding version?

swordfischer commented 11 years ago

No.

Cheeseness commented 11 years ago

We were also talking about popping these in http://mumble.sourceforge.net/Mumble_URL

swordfischer commented 11 years ago

Don't think that the expanding version is worth the effort.

Also, pretty sure that the url-ything is hard to achieve as it only knows the current path to the channel, and not the full path.

Cheeseness commented 11 years ago

I feel that the expanded version is a bit long, especially since we've got so many channels now.

I'm not sure I follow you on path stuff. If that's just the page not keeping track of the path as it iterates through the channels, that'll pretty trivial to keep track of.

swordfischer commented 11 years ago

Ah cool, I take it you make it then?

Long? We got more content on the other pages, like servers?

Cheeseness commented 11 years ago

I'm happy to give you a hand working it out if you need, but I'm not going to mess around with it on my own as there are other, higher priority features that need my attention, and I'm comfortable with the live page as it is now.

If you want to implement the Mumble channels as sortable tabular data like the servers page, then go nuts.

IIRC, the reason we started looking at this initially was to reduce the amount of space taken up with the current channel list and make the number/"location" of online users more readable. Not having an expanding tree seems to work against that.

swordfischer commented 9 years ago

Merged the change.

Cheeseness commented 9 years ago

Can you please revert these changes and commit them to the Master (staging) branch (preferrably as a pull request that can be reviewed).

Was removing the user list as well intentional?

swordfischer commented 9 years ago

No, it has been pending for over a year. Nobody bothered to accept it.

Yes, users are shown in the list now.

Cheeseness commented 9 years ago

Revert the commit and apply it to the Master (staging) branch, please. Do not let the live branch get ahead of Master.

"Nobody bothered to accept it" is also a poor response when there was unresolved discussion here along with an offer to assist with making changes.

johndrinkwater commented 9 years ago

Why does it need reverting; can it not be additionally applied to the other branch if necessary?

Cheeseness commented 9 years ago

Or do that, but then that'll make for a messy merge next time something else gets pushed to live.

Cheeseness commented 9 years ago

Sorted with #108 Thanks