Replace KeyValue implementation with ValveKeyValue library

SteamRE / SteamKit

SteamKit2 is a .NET library designed to interoperate with Valve's Steam network. It aims to provide a simple, yet extensible, interface to perform various actions on the network.

GNU Lesser General Public License v2.1

2.5k stars 478 forks source link

Replace KeyValue implementation with ValveKeyValue library #1289

Open xPaw opened 7 months ago

xPaw commented 7 months ago

Depends on https://github.com/ValveResourceFormat/ValveKeyValue/issues/30

Would have to figure out how to do it in a way to reduce breaking changes.

Fixes #258

yaakov-h commented 7 months ago

We could probably write a wrapper that keeps the old KeyValue API and flag it with a warning-class [Obsolete] attribute, to give consumers some time to migrate?

Do we need to keep binary compatibility, source compatibility, or neither-but-make-it-easy?

xPaw commented 7 months ago

Binary compat sounds like a bad idea considering we're going for .net 8 anyway.

And some SK apis use KeyValues so I'm not sure how obsolete helps if you can't migrate.