search

SteamRE / SteamKit

SteamKit2 is a .NET library designed to interoperate with Valve's Steam network. It aims to provide a simple, yet extensible, interface to perform various actions on the network.
GNU Lesser General Public License v2.1
2.62k stars 497 forks source link

WebAPI logs an AggregateException, rather than the actual exception #784

Closed yaakov-h closed 4 years ago

yaakov-h commented 5 years ago

https://github.com/SteamRE/SteamKit/blob/2.2.0/SteamKit2/SteamKit2/Steam/WebAPI/WebAPI.cs#L217-L225

Re-evalute the whole use of this continuation.

xPaw commented 4 years ago

Is there any point in this debug log? I would just remove that function and rename CallAsyncCore to CallAsync.

yaakov-h commented 4 years ago

(such as when waiting for the task times out, and an exception is thrown later)

This should no longer be neccesary with the new timeout APIs on HttpClient. It seems like a holdover from the HttpWebRequest/WebClient days.