bookmarklet link dynamically generated

SteamedPears / Code-Review

A web app for reviewing code (and other text), written in node.js using redis as the persistent store.

http://review.steamedpears.com

ISC License

1 stars 2 forks source link

Closed cdelahousse closed 11 years ago

psimonyi commented 11 years ago

Uh, are you missing a file? I don't see the code to generate the link anywhere.

psimonyi commented 11 years ago

... or I'm blind, or the page hadn't finished loading.

psimonyi commented 11 years ago

Should this be an inline script? Maybe it would be cleaner as a separate file. I'm not sure; does anyone else have an opinion?

cdelahousse commented 11 years ago

I figured if was nicer to keep it all together.

All the script files were nice and encapsulated and I didn't want to add another $(document).ready() function.

psimonyi commented 11 years ago

Okay, sure. Seems fine for now, anyway.