search

SteamedPears / CodeReviewClientMaster

Other
4 stars 3 forks source link

Don't grab all comments at once #4

Open spratt opened 12 years ago

spratt commented 12 years ago

We should probably just grab the comments in limited amounts. 50 at a time, maybe? This should make the page more responsive when there are lots of comments.

Gankra commented 12 years ago

As it's designed now we could store with the code a map of line numbers to comment numbers. Then only when someone clicks on the (#) do the comments get AJAX loaded in. I dunno how this would work with the back end, loading all the comments from one specific line, that is.

If there's too many comments on one line we can just load in the first 50 or something and have a "more..." button at the bottom that loads the next 50. Again the main challenge here is a back-end matter.

spratt commented 12 years ago

On the backend, it would be easy just to get the comments on a specific line number. Would it hurt responsiveness? We may want to think about the case where there are hundreds of comments on one line. Then again, we may want to leave that for our future selves to deal with.

Gankra commented 12 years ago

Details on expected resolution strategy here: https://github.com/SteamedPears/CodeReviewClientMaster/issues/46#issuecomment-6987610