Open spratt opened 12 years ago
This seems doable. Something like: [box with arrow pointing to code] "Select a portion of the code to comment on it or suggest a change."
If they select it: [box appears below the comment box] "Nice! Here you can discuss the selected portion of code. You can edit this copy of the code to provide suggested changes too!"
If they submit it: [box pointing to comments button] "Awesome! Click here to see your comment!"
And then maybe something about merging.
Exactly what I was thinking. Nothing complicated.
The question is just when to show it. We could show it to a new user the first time they submit code. What about an anonymous user? Every time? What about a new/anonymous user who isn't submitting code but has just been linked to this code base. What if there's already some comments on it?
I think we should show it any time there are no comments.
I dunno, I feel like being "f1rst" is generally a rare phenomenon. Anyone who doesn't get it won't have any way to know.
I think to a large extent, users will see other comments and try to figure out how to leave their own. Though if you have a better suggestion, I'd be interested to hear it.
It just doesn't seem intuitive. Especially since I just disabled clicking on a line to comment (must select). I'm at a loss for a superior alternative.
We'll talk about it at the meeting tonight.
Now that the interface is actually usable, we should start thinking about user experience. When the user first submits code, they are presented with a page that shows their code and whole bunch of empty space. If no comments have been made, we should have something which lets the user know they can select lines in the code to comment.