Steamopollys / Steamodded

A Balatro ModLoader
GNU General Public License v3.0
188 stars 42 forks source link

Rationalize prefixes #154

Closed Aurelius7309 closed 1 month ago

Aurelius7309 commented 1 month ago

Allows for consistent configuration of key prefixing across all classes (#144). Changes card_key for suits and ranks to comply with this. This field is no longer subject to automatic decollisioning and uses mod prefixes exclusively for this purpose. TODO:

english5040 commented 1 month ago

Palettes can be removed if it breaks and isn't easily fixable; AltTexture is going to replace it.

(still would be good for merge conflict reasons if palettes can be fixed)

Aurelius7309 commented 1 month ago

Stakes are fixed. Taking ownership of the data in place causes the stake level to come out wrong, causing other crashes, so this approach was not taken.

Aurelius7309 commented 1 month ago

There's a different issue relating to take_ownership where Blinds that have been taken ownership of are automatically discovered: #157. This doesn't happen to any other object types.

english5040 commented 1 month ago

The fact that taking ownership of stakes is broken is definitely an issue to be fixed

thinking about this: self.injected will always be properly set after the initial stakes have been injected; the initial stakes are a special case. I think this is a bit fragile though, bugs just waiting to happen with the current stake code. Also we are setting order in two different places