Negative card implementation is incomplete, will conflict with vanilla behavior

Steamopollys / Steamodded

A Balatro ModLoader

GNU General Public License v3.0

188 stars 42 forks source link

Negative card implementation is incomplete, will conflict with vanilla behavior #177

Closed english5040 closed 1 month ago

english5040 commented 1 month ago

The play area has a limit of -28 cards in it (should be 5) after a run with Perkeo.

This may be a bug with the Negative edition's implementation in Steamodded

english5040 commented 1 month ago

The above issue has been resolved, but there are still some things to do:

CardArea:change_size() doesn't respect negative cards
CardArea:change_size() sets real_card_limit which is supposed to keep track of your card_limit if it's negative; card_limit itself is set to 0. This may cause unexpected behaviors with negative cards (Note: change_size() is only ever called on G.hand)

Aurelius7309 commented 1 month ago

CardArea:change_size() not respecting negatives has been resolved by modifying real_card_limit when negative cards are drawn or removed. This seems to also resolve the other mentioned problem.