lovely patches to remove certain hardcoded UI checks related to current stake

[SpaD-Overolls]

first patch changes a stake > 1 into #.applied_stakes ~= 0 to determine whether the run info screen should have a stakes button second patch (admittedly too complex?) changes a stake > 2 check into a search that looks for the first stake with modifiers to determine whether the stake screen should have "also applies" boxes

[english5040]

Can you describe what your algorithm is doing? I was thinking, you make a descending pass through all stakes, keeping track of a set S (stakes that should be in the applied section). Whenever you encounter a stake in S, union its list of applied stakes into S.

I'll also say we should probably disallow defining a stake that applies a stake higher in the list.

[english5040]

To be honest Stakes are not really fully-featured yet

[SpaD-Overolls]

Can you describe what your algorithm is doing? I was thinking, you make a descending pass through all stakes, keeping track of a set S (stakes that should be in the applied section). Whenever you encounter a stake in S, union its list of applied stakes into S.

I'll also say we should probably disallow defining a stake that applies a stake higher in the list.

the algorithm starts at the current stake's .applied_stakes and checks:

1. Whether this stake has already been searched (to avoid entering infinite loops)
2. Whether this stake has a modifier.

If it hasn't been searched, it's added to the searched table and has it's applied stakes go through the algorithm. If it has a modifier, the found counter ticks up by 1.

• checking for modifiers is done separately from searched stakes to ensure that having a stake that doesnt define its own modifier doesn't cut off earlier stakes that do have modifiers (doesn't naturally happen in vanilla though)
• since that part of the code only needs to know whether any other stake applies additional modifiers, it cuts off the loop as soon as it finds the first valid stake with a modifier. (going through stakes to actually draw their effects in the menu is handled by a steamodded function that runs if the check that im patching succeeds)

the goal of these changes is to have these two ui elements define themselves based on the current stake's data instead of the current stake's number.