search

Stebalien / tempfile

Temporary file library for rust
http://stebalien.com/projects/tempfile-rs
Apache License 2.0
1.2k stars 120 forks source link

allow older windows-sys 0.52 #304

Closed king-11 closed 2 weeks ago

king-11 commented 2 weeks ago

dependabot bumped the version to 0.59 but older version 0.52 can also be supported allowing downstream crates to pull dependency as per their version choice.

Stebalien commented 2 weeks ago

Why?

king-11 commented 2 weeks ago

I don't think tempfile makes use of any API change which might have been introduced with 0.59 so keeping the range would prevent dependency hell for other downstream dependencies to only pull one version and I have mostly found that to be version 0.52.

Stebalien commented 2 weeks ago

Hm. There's no guarantee that'll work as you expect (https://github.com/rust-lang/cargo/issues/10599) but it's unlikely to hurt given that this dependency isn't exported.

king-11 commented 2 weeks ago

Yep the resolver can't really make out of this NP hard problem but many a times it works and gets the right one.

Stebalien commented 2 weeks ago

3.14 published