search

Stebalien / term

A Rust library for terminfo parsing and terminal colors.
https://stebalien.github.io/doc/term/term/
Apache License 2.0
178 stars 49 forks source link

Update unary negation of unsigned integers #23

Closed IvanUkhov closed 9 years ago

IvanUkhov commented 9 years ago

Hi,

The pull request addresses the problem discovered in rust-lang/cargo#1480. Unfortunately I don’t have a proper environment to test the code; I was guided by the error log.

Regards, Ivan

rust-highfive commented 9 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

alexcrichton commented 9 years ago

Thanks! I personally think that !10 is kinda tough to read though when compared to -11, would you be ok changing this to -11i32 as libc::DWORD?

IvanUkhov commented 9 years ago

@alexcrichton, I like your idea much better. I’ve rewritten the commit, but I don’t see any update here. Somehow GitHub hasn’t picked it up.

alexcrichton commented 9 years ago

Perhaps it was a force push to the wrong branch by accident?

IvanUkhov commented 9 years ago

@alexcrichton, yes, a force push, but to the same branch.

alexcrichton commented 9 years ago

Whoa I tried to close and reopen but now it won't let me reopen...

Wanna retry the PR?

alexcrichton commented 9 years ago

"The negative-unsigned branch was force-pushed or recreated."

Github why you do this to me :(