search

Stebalien / term

A Rust library for terminfo parsing and terminal colors.
https://stebalien.github.io/doc/term/term/
Apache License 2.0
178 stars 49 forks source link

Documented function of `delete_line` is more like `clr_eol` #68

Closed sourcefrog closed 7 years ago

sourcefrog commented 7 years ago

Fixes https://github.com/Stebalien/term/issues/67.

In terminfo as far as I can make out, dl means delete the current line and move up from below, whereas your term.delete_line is described as deleting to the end of the line.

Possibly this should be fixed in the other direction by adding a new function, and updating the delete_line behavior. But I think the current docstring is accurate on Windows.

Stebalien commented 7 years ago

You have the correct fix, sorry for the delay. However, terminfo currently uses the short names so the correct capability would be el. Unfortunately, that specific short name hadn't been filled-in in the database yet. Could you rebase on the latest master (and use el instead of clr_eol)?

Stebalien commented 7 years ago

Given that I completely forgot about this and left you hanging for weeks, I decided to just make the change for you and merge.

sourcefrog commented 7 years ago

Thanks!

On Wed, Jan 25, 2017, 5:15 PM Steven Allen notifications@github.com wrote:

Given that I completely forgot about this and left you hanging for weeks, I decided to just make the change for you and merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Stebalien/term/pull/68#issuecomment-275283225, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVI80NsoI23-WdBhLy2Nwgkypa0PeSQks5rV_OhgaJpZM4LUa34 .