search

Steeeephen / LAVA

LoL Automated Video Analytics: Open-Source VoD Analytics Tool for League of Legends
https://github.com/Steeeephen/LAVA/wiki
Apache License 2.0
27 stars 2 forks source link

Indentation #21

Closed Allan-Cao closed 1 year ago

Allan-Cao commented 1 year ago

Hi! I'm wondering if we could change the global styling to match PEP-8 guidelines with four spaces of indentation.

Steeeephen commented 1 year ago

It's definitely the plan and is fairly low-hanging fruit, a big refactor is needed and pep8 will be a part of it for sure

Allan-Cao commented 1 year ago

I can apply this styling as well as other stylings with black fairly easily. Perhaps we can adopt that code formatting? https://github.com/psf/black

Allan-Cao commented 1 year ago

See PR #22 for black formatting

Steeeephen commented 1 year ago

ah damn you beat me to it, merged #23 already. The other OSS I'm maintaining just go with flake8 and base pep8 rather than black so may as well stick to it