Steelhacks-2023 / Lost-At-Pitt

Lost @ Pitt is a multi-platform lost-and-found tracking application, allowing users to return & reclaim lost items. Currently in development!
https://steelhacks-2023.github.io/Lost-At-Pitt/
6 stars 0 forks source link

No way to navigate back from lost and found card #26

Closed jeffzheng13 closed 9 months ago

jeffzheng13 commented 10 months ago

IDENTIFIER: DEFECT-NAVIGATE-LOST-FOUND-CARD

SUMMARY: There is no way to navigate back to the map after clicking on the marker

DESCRIPTION: There is no way to navigate back to the map after clicking on the marker which pulls up a card displaying the item that was lost or found information.

REPRODUCTION STEPS:

EXPECTED BEHAVIOR: Card should disappear and map should be clickable again.

OBSERVED BEHAVIOR: No way to exit. Clicking [esc] on the keyboard works, but is impractical for mobile devices.

tbeidlershenk commented 10 months ago

Yeah we could just add an X button to quit out of the sub page, or make the screen outside of the subpage clickable to return to the original page

@jeffzheng13 if you want to work on this, notice how in route.dart the routed page is wrapped in a PointerInterceptor widget which was my solution to stop the MapPage from being clickable underneath.

tbeidlershenk commented 9 months ago

Still need an X button on PostPage.dart

jeffzheng13 commented 9 months ago

Yeah we could just add an X button to quit out of the sub page, or make the screen outside of the subpage clickable to return to the original page

@jeffzheng13 if you want to work on this, notice how in route.dart the routed page is wrapped in a PointerInterceptor widget which was my solution to stop the MapPage from being clickable underneath.

Wanted to avoid this routing with a PointerInterceptor for the ItemRequest form as it needed to refresh the map on return, so markers reset. To keep the same formatting, on PostPage.dart, I just added a X button that would pop back to map page (no reload required). I could also add the PointerInterceptor stuff, but popping the page instead of pushing another on seems much more reasonable.