Update bootstrap, jquery, copyright and local-mainsite link

SteeltoeOSS / Documentation

The documentation, api browser, and getting started guides used for the Steeltoe's website.

Apache License 2.0

8 stars 23 forks source link

Update bootstrap, jquery, copyright and local-mainsite link #310

Closed TimHess closed 7 months ago

TimHess commented 8 months ago

also updates site nav to match mainsite as of https://github.com/SteeltoeOSS/MainSite/pull/141

TimHess commented 7 months ago

Issues identified reviewing https://github.com/SteeltoeOSS/MainSite/pull/141 that still need to be fixed:

[x] Make the browser window smaller, so the top-level menu changes into a hamburger menu. Then clicking the hamburger menu shortly expands its entries before auto-collapsing again. It's currently impossible to keep it visible. It works properly on MainSite.
[x] Get started > API Browser: left-side version-selector panel with namespaces does not appear
[x] Review this commit, ensure merge-ability and bring non-v4 enhancements to main

TimHess commented 7 months ago

This PR is now (manually) deployed and paired with the mainsite pr preview site

bart-vmware commented 7 months ago

Menu buttons are still broken. Repro:

Click "Why Steeltoe" (expands)
Click it again (bug: does not collapse)
Click "Get Started" (collapses "Why Steeltoe" and expands "Get Started")
Click "Why Steeltoe" (bug: now you see both menus)

bart-vmware commented 7 months ago

Issues identified reviewing SteeltoeOSS/MainSite#141 that still need to be fixed:

Make the browser window smaller, so the top-level menu changes into a hamburger menu. Then clicking the hamburger menu shortly expands its entries before auto-collapsing again. It's currently impossible to keep it visible. It works properly on MainSite.

Get started > API Browser: left-side version-selector panel with namespaces does not appear

Review this commit, ensure merge-ability and bring non-v4 enhancements to main

If fixing these is not going to be part of this PR, do we have a tracking issue to address them later?

github-actions[bot] commented 7 months ago

Preview link: https://docs-steeltoe-pr-310.azurewebsites.net

Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

TimHess commented 7 months ago

Looking at #310 (comment), I'm still seeing the following issues:

Still broken on Docs, works on MainSite: Update bootstrap, jquery, copyright and local-mainsite link #310 (comment)

Very small browser, open hamburger menu, click Get Started: border around submenu entries is missing. Docs:

vs MainSite:

Small browser (a bit wider than above), open hamburger menu: Top-level menu entries are left-aligned instead of centered. And the menu now overlays existing content instead of insertion. Docs:

vs MainSite:

The differences are caused by significant interference from docfx here... I can try to fix it now, but I'm not sure how much effort it's worth if we follow up on updating docfx (which I think is something we should do soon)

bart-vmware commented 7 months ago

Now seeing another script error at https://docs-steeltoe-pr-310.azurewebsites.net/api/v3/stream/:

Uncaught SyntaxError: Unexpected token 'catch' (at main1.js:103:5)

bart-vmware commented 7 months ago

The active tab is no longer colored in API browser when clicking on it. This worked earlier today.