SteeltoeOSS / InitializrConfig

Configuration store for Steeltoe.Initializr.ConfigServer
Apache License 2.0
0 stars 3 forks source link

Add .NET 5 as an option once 3.0.2 is released #59

Closed jkonicki closed 3 years ago

ccheetham commented 3 years ago

There'll need to be some code changes to support .NET 5.

The current impl uses a version comparison that includes a sanity check if the versions being compared have alpha prefix.

E.g., given 2 version strings, "netcoreapp2.1" and "netcoreapp3.1", the version comparison will result in the former being less than (earlier) the latter.

If, however, given 2 version strings "netcoreapp3.1" and "net5.0", the code will throw an exception complaining the prefixes don't match.

The impetus for the check was the possibility of having to support .NET Framework. Framework and core have different release trains so the check was to help prevent against, e.g. .NET Framework 4 being considered greater than (newer) .Net Core 2 or 3.

Possible logic changes to support .NET 5 include:

ccheetham commented 3 years ago

Version comparison changed so that, e.g., netcoreapp2.1 and net5.0 can be compared. See: https://github.com/SteeltoeOSS/InitializrApi/commit/3de9dfadcacce054a8475826d9d57e927d20840b