search

SteeltoeOSS / InitializrWeb

Reference implementation of a Steeltoe Initializr UI project generator
Apache License 2.0
5 stars 4 forks source link

Using shared URL shows incorrect error that Steeltoe version not supported #51

Closed ccheetham closed 3 years ago

ccheetham commented 3 years ago

Using this URL: http://start-staging.steeltoe.io/#!name=Sample2&namespace=Sample233&applicationName=Sample2Application333&description=Sample2%20application%20project45454&steeltoeVersion=2.5.1&dotNetFramework=netcoreapp3.1&dotNetTemplate=webapi&language=csharp&packaging=zip&dependencies=config-server,circuit-breaker,actuator,azure-spring-cloud

... yields "Requires Steeltoe m>= 2.4.0 and < 3.0.0" error. No error should be reported.

Screen Shot 2020-11-17 at 6.26.33 AM.png

ccheetham commented 3 years ago

Doesn't seem to be an error introduced by Steeltoe mods. Spring site behaves similarly: https://start.spring.io/#!type=maven-project&language=java&platformVersion=2.2.11.RELEASE&packaging=jar&jvmVersion=11&groupId=com.example&artifactId=demo&name=demo&description=Demo%20project%20for%20Spring%20Boot&packageName=com.example.demo&dependencies=thymeleaf,vaadin

ccheetham commented 3 years ago

Fixed in upcoming 1.0.2

ccheetham commented 3 years ago

Should be noted that if, e.g., the Steeltoe version is no longer available, no error is reported. A generated project will use the no-longer-available Steeltoe version. It's not clear what the proper behavior should be, but this current behavior can be justified.