SteeltoeOSS / Samples

Steeltoe samples and reference application collection
https://steeltoe.io/
Apache License 2.0
641 stars 250 forks source link

Refresh connector samples (on main branch) #279

Closed bart-vmware closed 1 year ago

bart-vmware commented 1 year ago

Updated connector samples, based on default MvcWebApplication project template, targeting ~.NET 7~ .NET 6:

Review notes:

TimHess commented 1 year ago

This generally looks good to me. As discussed in the team call earlier today, if the samples in main can continue to target .NET 6 I think that is preferred for now. If that change introduces significant rework, then it would be OK to target .NET 7.

bart-vmware commented 1 year ago

This generally looks good to me. As discussed in the team call earlier today, if the samples in main can continue to target .NET 6 I think that is preferred for now. If that change introduces significant rework, then it would be OK to target .NET 7.

Locally they all work on .NET 6, except for the SQL Server sample. That's because it requires https://github.com/SteeltoeOSS/Steeltoe/pull/1094, but the pre-release version number on SteeltoeDev feed is incorrect, so it picks the stable v3.2.2 instead.

Update: The SQL Server issue was resolved by https://github.com/SteeltoeOSS/Steeltoe/pull/1096.