search

SteeltoeOSS / Steeltoe

.NET Components for Externalized Configuration, Database Connectors, Service Discovery, Logging and Distributed Tracing, Application Management, Security, and more.
https://steeltoe.io
Apache License 2.0
1k stars 164 forks source link

Config server URLs appear encoded in logs #1316

Closed macsux closed 1 month ago

macsux commented 2 months ago

Describe the bug

The following appears in logs

info: Steeltoe.Configuration.ConfigServer.ConfigServerConfigurationProvider[0]
      Fetching configuration from server at: http://127.0.0.1:8888            
info: Steeltoe.Configuration.ConfigServer.ConfigServerConfigurationProvider[0]      
      Config Server returned status: OK invoking path: http%3A%2F%2F127.0.0.1%3A8888
info: Steeltoe.Configuration.ConfigServer.ConfigServerConfigurationProvider[0]                                    
      Located environment name: cpdemo-blue, profiles: Development, labels: (null), version: (null), state: (null)

Those URLs look encoded

Steps to reproduce

Steps to reproduce the behavior:

  1. Add config server using WebApplicationBuilder like so builder.AddConfigServer();

Expected behavior

Urls to appear non-url encoded

Environment (please complete the following information):

TimHess commented 2 months ago

This would also be another opportunity to review the level at which Steeltoe is logging... The second and third entries should maybe be debug/trace instead of info