search

SteeltoeOSS / Steeltoe

.NET Components for Externalized Configuration, Database Connectors, Service Discovery, Logging and Distributed Tracing, Application Management, Security, and more.
https://steeltoe.io
Apache License 2.0
1k stars 164 forks source link

Silent Test Failure - SpringCloudConfigServer_DiscoveryFirst_ReturnsExpectedDefaultData #521

Open TimHess opened 3 years ago

TimHess commented 3 years ago

This integration test requires both a config server and a service registry, and the config server needs to be registered with the registry.

Without failFast=true this test was "passing" even though the above pre-requisites weren't met. #515 skips the test and sets this property so that we'll have a more accurate representation of what's happening when the pre-requisites can be met. Use this issue as a reminder to enhance the docker image and un-skip the test

jkonicki commented 3 years ago

The config server image needs to be enhanced to work with discovery first

bart-vmware commented 1 month ago

@TimHess What's needed to get this resolved? We now have a config-server image that supports discovery, but the cibuild doesn't start a Eureka instance. I wonder if it should, as it may take several minutes for Eureka to refresh, which is impractical.

TimHess commented 1 month ago

I would think Eureka would be ready in <60 seconds, but we'll have to see what actually happens in the CI environment. We could add the command to start Eureka as the first step in the jobs (at least for component builds) to help mitigate the startup time

I think it's just removing the skip and making sure the Config server start command has -e eureka.client.enabled=true added