search

Steem-FOSSbot / steem-fossbot-voter

A curation bot built for the Steemit social media platform, decides which posts to vote for and casts vote on behalf of a registered user
Other
94 stars 336 forks source link

Author blacklist / Whitelist / is Followed vars do not work #133

Closed prosmacs closed 6 years ago

prosmacs commented 6 years ago

Since a while i have noticed that the rule author_is_blacklisted does not work anymore. I have the same issue for author_is_whitelisted and author_is_followed. I noticed the issue, when i saw that authors still get votes after i blacklisted them. So i checked the stats. I saw than that also whitelisted authors and followed authors get no points even tough i assigned them 15 ponts for whitlisted and 7,5 for followed. Blacklisted authors i assigned -75 points which should exlude them from votes. As you can see here in my screenshot the concerning mettrics do not show up in the chart, also treshold is very low. http://fs1.directupload.net/images/180407/pdbyd8wv.png. I wrote this three issues in one ticket because they all have in common that they concern lists of author. So i concluded that they have one common cause.

ghost commented 6 years ago

Great, thanks for sharing this issue, I'll investigate it now

ghost commented 6 years ago

Turns out the issue is in getting the account from the Steemit API

error, can't get user accounts: FetchError: invalid json response body at https://api.steemit.com reason: Unexpected token < in JSON at position 0

This is probably because the bot tries to get an unbounded number of accounts from the API. I ran a test with 4000 posts processed and I had a list of 33330 account tried to get from the API in one call!

ghost commented 6 years ago

Basic use case is fixed, should test this a lot

ghost commented 6 years ago

Available in v0.3.2