This pull request introduces modifications to the 'NIFTI_NORDIC.m' script to integrate it with a Nipype workflow, which necessitates new code to handle interactions with Python-generated '.mat' files.
Compatibility Note
The updated script is no longer compatible with the original standalone MATLAB usage, which relies on a MATLAB structure (ARG) as an (optional) input. The new version requires a Python-generated .mat file for its operation, which however is also optional.
Changes
Made minor adjustments to the existing NIFTI_NRODIC.m to support the integration with Nipype:
New code is added to handle .mat files from Python.
The script has been renamed to NIFTI_NORDIC_nipype.m, which also reflects the renaming of the associated function within the script.
Added a new Python module NiftiNordic in NIFTI_NORDIC_interface.py to wrap the NIFTI_NORDIC_nipype.m script for Nipype compatibility.
Included example_usage_NORDIC_nipype.ipynb, a Jupyter Notebook that demonstrates how to use the new Nipype interface with fMRI data and compute TSNR maps.
Proposal
Given that these changes alter the functionality of the original script, I propose that they be merged into a new branch (e.g., nipype-integration) rather than the main branch. This would allow users who work with Nipype to benefit from these modifications without disrupting the original functionality of the NORDIC_raw repository.
Please review and let me know if any adjustments are needed.
Summary of Changes
This pull request introduces modifications to the 'NIFTI_NORDIC.m' script to integrate it with a Nipype workflow, which necessitates new code to handle interactions with Python-generated '.mat' files.
Compatibility Note The updated script is no longer compatible with the original standalone MATLAB usage, which relies on a MATLAB structure (ARG) as an (optional) input. The new version requires a Python-generated .mat file for its operation, which however is also optional.
Changes
Made minor adjustments to the existing
NIFTI_NRODIC.mto support the integration with Nipype:NIFTI_NORDIC_nipype.m, which also reflects the renaming of the associated function within the script.Added a new Python module NiftiNordic in
NIFTI_NORDIC_interface.pyto wrap theNIFTI_NORDIC_nipype.mscript for Nipype compatibility.Included
example_usage_NORDIC_nipype.ipynb, a Jupyter Notebook that demonstrates how to use the new Nipype interface with fMRI data and compute TSNR maps.Proposal
Given that these changes alter the functionality of the original script, I propose that they be merged into a new branch (e.g.,
nipype-integration) rather than themainbranch. This would allow users who work with Nipype to benefit from these modifications without disrupting the original functionality of theNORDIC_rawrepository. Please review and let me know if any adjustments are needed.