search

StefH / PrimeNG-DataTable-Extensions

OData extensions for the PrimeNG DataTable
MIT License
10 stars 0 forks source link

Problem with out-of-date devDependency Http #18

Closed sebaiona closed 6 years ago

sebaiona commented 6 years ago

Hi,

I'm currently using your extension and it works great (thanks by the way !).

I juste have one little problem due to the devDependencies out of date. I use an HttpInterceptor which intercepts the http requests done by HttpClient (I think both were introduced in angular 4.3).

Given though PrimeNG-DataTable-Extensions have an old dependency to Http the interceptor doesn't work...

I just tried to copy the code in my solution and it works great (all the up-to-date dependencies doesn't create any error).

If you could just update the dependencies of the package, everything should work fine !

Thanks in advance !

StefH commented 6 years ago

Thanks for reporting.

I'll update dependencies for Angular to latest 4.x.x version. I'll also update primeng.

sebaiona commented 6 years ago

We're even in 5.0.5 now, and still no problem ;)

Thanks in advance!!

StefH commented 6 years ago

NPM is updated, Please test.

sebaiona commented 6 years ago

I forgot to mention that angular-odata-es5 is out of date too...

When I do applyLazyLoadEvent, I have this error :

Argument of type 'ODataQuery<T>' is not assignable to parameter of type 'ODataQuery<T>'.
Types have separate declarations of a private property '_filter'.

I guess my ODataQuery is too recent for the function in the current state... (it seems to be the only problem)

StefH commented 6 years ago

Sorry. I'll fix it again.

sebaiona commented 6 years ago

No problem. Let me know when it's done and I'll test as soon as I can ;)

StefH commented 6 years ago

please retest

sebaiona commented 6 years ago

Can you update it on npm please.

Given though what I saw, it should be ok !

StefH commented 6 years ago

npm version 0.0.4 uploaded

sebaiona commented 6 years ago

Thank you very much, everything is working fine !