Some issues with naming and other feedback...

[netclectic]

I tried to generate a client for the Jira api - https://developer.atlassian.com/cloud/jira/platform/swagger-v3.v3.json

Its a bit of a beast and throws up some issues that would be nice if they could be handled...

• some types like AvatarUrlsBean has properties with names like 16x16, 24x24 etc, these don't map to valid c# property names
• some types have properties with the same name as the type, e.g. IssueLinkTypes has a property issueLinkTypes which becomes IssueLinkTypes in the generated class, not valid in c#
• this highlights a general issue with naming: as the property name is changed to be uppercase, a json property name attribute should probably be applied on the generated property
• on the organisation side, it would be nice if the generated model classes were split into separate files and into a models folder, possibly even further split into sub-folders based on the api structure but I guess that could get messy quickly
• some type names result in ambiguous references, e.g. there is a generated class named Version with clashes with System.Version, possibly use some using alias for known system types
• some methods accepting multi-part form data have resulted in incomplete extension methods ,e.g.

  public static Task SetColumnsAsync(this IJiraApi api, string contentType, long id)
      {
          return api.SetColumnsAsync(contentType, id, content);
      }

That's as far as I've got just now to get to the point of a solution that builds, I'll try and give some more feedback as I try to get to a working solution.

[StefH]

Hello @netclectic, thank you for the analysis. I'll check the code and see if this can be updated.

(Do you use the VS plugin or the NuGet?)

[StefH]

@netclectic

I did some large refactoring in the code to support the Azure Rest API's and I'm also looking into your issue here.

Fixed

• some types like AvatarUrlsBean has properties with names like 16x16, 24x24 etc, these don't map to valid c# property names
• some types have properties with the same name as the type, e.g. IssueLinkTypes has a property issueLinkTypes which becomes IssueLinkTypes in the generated class, not valid in c#
• some methods accepting multi-part form data have resulted in incomplete extension methods ,e.g.

Pending

• some type names result in ambiguous references, e.g. there is a generated class named Version with clashes with System.Version, possibly use some using alias for known system types

More details ; see https://github.com/StefH/RestEase-Client-Generator/tree/jira