Closed StefH closed 5 years ago
@Lej Thanks for your review.
Code has been changed. Please check again.
@Lej Thanks for your review.
Code has been changed. Please check again.
Looks like it should work now. Had a small comment, not sure if relevant.
This seems to fix round for the 2.5 case, but round still fails for negative numbers when
MidpointRounding.ToEven
causes rounding towards negative infinity.Below expanded unit test where the case [InlineData("-3.5", -3)] fails (it is rounded to -4 when it should be rounded to -3). Note that I changed
string xpath = "round(number(value))";
tostring xpath = "round(xs:double(value))";
to test some edge cases.