StefH / XPath2.Net

Lightweight XPath2 for .NET
Microsoft Public License
36 stars 14 forks source link

Wrong version of XPath.dll is packaged in the 1.0.10 nupkg for net40 #29

Closed tizubythefizo closed 4 years ago

tizubythefizo commented 4 years ago

Hi there.

It looks like the net40 folder of the nupkg for version 1.0.10 actually contains the dll for version 1.0.9

This causes the wrong version to be present in .net 4.0+ projects (such as a unit test project), which causes runtime failures when another library (such as XPath2.extensions) expects to find version 1.0.10

In my setup I have a .net standard 2.0 library which references XPath2.extensions. I then have a unit test project for the library (which is .net 4.7.2). I use nuget to load in XPath2.extensions (which in turn adds XPath2). XPath2 extensions is expecting XPath2 v 1.0.10, but 1.0.9 ends up being loaded resulting in a "missing file or assembly" exception at runetime.

xpath2

StefH commented 4 years ago

Thanks for noticing this issue.

Can you try preview version from MyGet : XPath2.1.0.11 ?

https://github.com/StefH/XPath2.Net/pull/30

tizubythefizo commented 4 years ago

I'm not really sure what myget is.

StefH commented 4 years ago

I did upload the 1.0.11 version to MyGet : https://www.myget.org/feed/xpath2/package/nuget/XPath2

See https://github.com/WireMock-Net/WireMock.Net/wiki/MyGet-preview-versions fir example how to use this

tizubythefizo commented 4 years ago

Looks like 1.0.11 does build correctly at the proper versions.

StefH commented 4 years ago

New official NuGet will be released soon.