search

StefH / XPath2.Net

Lightweight XPath2 for .NET
Microsoft Public License
36 stars 14 forks source link

Check both default namespace and NsXQueryFunc when binding functions #39

Open binarycow opened 4 years ago

binarycow commented 4 years ago

If a document has the default namespace set, FunctionTable.Bind will use that namespace to resolve a function name.

This change will use the default NsXQueryFunc namespace URI if a function does not exist for the user specified namespace URI.

StefH commented 4 years ago

@binarycow The unit test fail, can you please check?

And also run the https://github.com/StefH/XPath2.Net/tree/master/src/XQTSRun tool to check if the same coverage in % is as before.

binarycow commented 4 years ago

The unit tests in VS all pass. The XQTSRun tool needs a file? Where do I get that file?

StefH commented 4 years ago
  1. The unit tests on build server fail.
  2. https://github.com/StefH/XPath2.Net#info has info on how to get the set
StefH commented 3 years ago

@binarycow Can you merge latest master from my project into your branch ? I did fix some CI build things.

binarycow commented 3 years ago

@StefH - rebased

StefH commented 3 years ago

@binarycow Thanks.

Can you once verify if all tests pass? ""conforms for 12954 from 15133""

StefH commented 3 years ago

@binarycow Thanks.

Did you have time to verify if all tests pass? ""conforms for 12954 from 15133""

StefH commented 3 years ago

@binarycow I did merge latest master into your branch. And now all the tests from the test suite are also run as a unit test.

And with this change, the test K-SeqExprCast-1422 fails.

Can you investigate ?

StefH commented 1 year ago

@binarycow Did you have time to check why test K-SeqExprCast-1422 fails?