search

StefMa / hugo-fresh

Hugo Fresh Theme
https://hugo-fresh.vercel.app
MIT License
588 stars 337 forks source link

_internal/google_analytics_async.html is no longer supported by Google and will be removed in a future version of Hugo #195

Closed dogmatic69 closed 3 weeks ago

dogmatic69 commented 3 months ago

as per title

StefMa commented 3 months ago

Hey, thanks for the issue! Could you provide a link/source to this information? 🙏

dogmatic69 commented 3 months ago

It's in the logs when running the server, not looked much into it

brianmgray commented 2 months ago

I see it too. It looks like this is the problem: https://github.com/StefMa/hugo-fresh/blob/b863b0d98d76c4e86dd09b76c889caa420387b1c/layouts/partials/meta.html#L1

Per this: https://github.com/gohugoio/hugo/issues/10899, it looks like this template is deprecated

StefMa commented 2 months ago

I investiaged a bit and it seems that the _internal/google_analytics_async.html template is deprecated. But not the _internal/google_analytics.html one. (Note the _async here 🙃 ) See also https://github.com/gohugoio/hugo/pull/11468/files

This was already changed in this PR.

The mentioned PR was merged at 14.3.2023 (close to a year ago 😁) while the 1.0.0 release happen at 5.3.2023.

So it seems I only have to do another release to fix this.

Do you guys using hugo mod? Could you try to use the latest git hash to check if the warning disappear?

StefMa commented 3 weeks ago

v1.1.0 is out. See https://github.com/StefMa/hugo-fresh/releases/tag/v1.1.0

This issues is obsolete now. Going to be close it.