search

Stefan-Endres / DWPM-Mixture-Model

Phase seperation calculation using the DWPM mixture rule.
7 stars 3 forks source link

Travis CI data access #38

Open Stefan-Endres opened 8 years ago

Stefan-Endres commented 8 years ago

The build unittests are failing because the config.cfg file is not in the public GitHub repository, when a customized one is added it cannot find the correct directory where the data is stored locally.

Is there anyway to fix this? Maybe by adding a remote data storage for the .csv files?

alchemyst commented 8 years ago

The real issue is that the tests shouldn't require the data. The good way to handle this would be to use mock to build an object which does the same things as the data object but for the (hopefully) smaller cases that the tests test. These difficulties with testing the routines in isolation indicate design problems, and we should avoid just plastering over them.

Stefan-Endres commented 8 years ago

I agree. I will keep this issue open until we deal with fixing the data handling entirely.