Stefan-Endres / shgo

Simplicial Homology Global Optimization
https://stefan-endres.github.io/shgo
MIT License
44 stars 12 forks source link

Remove functions from sobol_seq.py #10

Closed alchemyst closed 6 years ago

alchemyst commented 6 years ago

There are functions in sobol_seq.py which are not used.

The less code we have, the less we need to maintain.

Stefan-Endres commented 6 years ago

I was getting some strange import errors when I tried to run the unittests where it's searching for a missing attribute of the module even though we just import everything with *. I've changed the way these functions functions are imported and removed these functions in dcbf6f9491b3fbf8584fc4acba2c98628c2e62b0.

alchemyst commented 6 years ago

I think the issue is that you didn't remove the functions from the __all__ for the module.

alchemyst commented 6 years ago

I've removed one more function and updated __all__ in de59e0d0df1e70b07b7efefad891492e181cae54

Stefan-Endres commented 6 years ago

Ah, thank you!