search

Stefan-Endres / shgo

Simplicial Homology Global Optimization
https://stefan-endres.github.io/shgo
MIT License
44 stars 12 forks source link

More general cleanup #26

Closed alchemyst closed 6 years ago

alchemyst commented 6 years ago

No big changes except for lots of code reduction due to extracting a superclass for Cell and Simplex, which were basically copy-pasted versions of each other.

Another notable small change is in using _min instead of min to store the "private" variable for the minimum value. This is a convention discussed in PEP8's "Designing for inheritance" section.

I've also removed lots of vestigial commented bits of code. As I mentioned before, it is far better to split alternative implementations into different branches than to have this kind of stuff hanging around in the active code base, since it causes extra cognitive load when reading the code ("Why is this here, would that be better?").

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.163% when pulling d1bc835a2895d0067f001f6c94667316b7063c59 on cleanup into 2c64020b1b8671597c759eb0553f375dc28841ad on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.163% when pulling d1bc835a2895d0067f001f6c94667316b7063c59 on cleanup into 2c64020b1b8671597c759eb0553f375dc28841ad on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.163% when pulling ed14b52c713d21ed45c8aaa51e9f6c605236fe34 on cleanup into 2c64020b1b8671597c759eb0553f375dc28841ad on master.

alchemyst commented 6 years ago

The issues that codeclimate is moaning about are bogus.