Stefan-Endres / shgo

Simplicial Homology Global Optimization
https://stefan-endres.github.io/shgo
MIT License
44 stars 12 forks source link

Merge universal_iters branch with master #6

Closed Stefan-Endres closed 7 years ago

Stefan-Endres commented 7 years ago

The universal_iters branch is a major restructuring of the code with the following benefits:

Unfortunately, it is not a simple refactoring since the inputs (n and iters arguments) actually need to be changed slightly to produce the same outputs in the overall routine, although the same behaviour should (at least theoretically) be possible to replicate given the correct usage of these parameters. The 3 unittests for ambiguous unittests also need to be removed since they are no longer ambiguous, but can used in a customized optimisation run. All other unittests are kept and working with little to no modifications.

However, just because the unittests are working does not mean the performance has been maintained. Therefore we need a way to compare performance of the two branches in addition to replicating the performance shown in publications. One possibility is adding unittests assessing the function evaluations of the current master branch. Finally some of the changes allowing for Python compatibility other than Python 3.6 which were committed to the master branch need to be rechecked with the new code.

Stefan-Endres commented 7 years ago

Started PR #7

Stefan-Endres commented 7 years ago

Merged PR #7. After testing on python 2.7 we can close this issue.

Stefan-Endres commented 7 years ago

Working at 0cdf138.