StefanKert / BuildVision

A Visual Studio extension to visualize the building process.
MIT License
261 stars 43 forks source link

Please support Visual Studio 2019 #68

Closed willl closed 5 years ago

willl commented 5 years ago

Visual Studio 2019 preview 1 has been released https://blogs.msdn.microsoft.com/visualstudio/2018/12/04/making-every-developer-more-productive-with-visual-studio-2019/

And a blog post on how to upgrade the extension to support it https://blogs.msdn.microsoft.com/visualstudio/2018/09/26/how-to-upgrade-extensions-to-support-visual-studio-2019/

StefanKert commented 5 years ago

First of all sorry for the delay:

To give you guys a quick update on this issue:

Since @Stelzi79 changed the manifests to make it work with 2019 there is already a working version for 2019. You can grab the .vsix here.

As @NickCraver mentioned on Twitter (https://twitter.com/Nick_Craver/status/1073668510532943873) there is still a warning that says that BuildVision is not loaded in an async way. This is not really a blocker but will probably be an issue in the future so for the next release I plan to have BuildVision loading asynchrounously. For this purpose I need to do some more work and as it is hoilday season I am currently spending my time with the family so there is not much time left to work on this. Nevertheless I had some minutes to try to migrate some bits but it seems like this involves some bigger changes which also will bring some performance improvements on BuildVision load times (VS startup).

So once again sorry for the delay and I hope I can give an update on this case in the next weeks.

Cheers!

xperiandri commented 5 years ago

You can check my changes to another extension for async load support https://github.com/madskristensen/DialToolsForVS/commits/master

xperiandri commented 5 years ago

I tried to download your VSIX but I'm not authorized

StefanKert commented 5 years ago

Oh sorry! Looks like I used the wrong link.

Thanks for the heads up:

https://stefankert.visualstudio.com/BuildVision/_build/results?buildId=26

This link should work. If you navigate to artifacts there should be a .vsix.

Also thanks for the link, I will check that and if possible get back to you with some questions.

I‘ve managed to migrate to AsyncPackage but since there are still a lot of warnings I am currently trying to resolve them and do further improvements on the code.

By the end of next week I should have a first preview of 3.0

xperiandri commented 5 years ago

Thanks. Sounds amazing!

willl commented 5 years ago

@StefanKert Thanks for the update. I've downloaded it and it appears to be working!

NickCraver commented 5 years ago

Is there any update on listing this in the extensions gallery? I love it and have been trying the latest builds every so often, just wondering on status :) I'm also talking to the VS team about why IMO this should be in the box for everyone...it's such an awesome feature. At the very least, the stop on first build failure should be a VS option.

StefanKert commented 5 years ago

@NickCraver I am currently in the process of rewriting most of the BuildVision code and also trying to get up a Unittest and an IntegrationTest project to make it easier to contribute. As soon as I have these integrationtests up and running in Azure DevOps I will include the pipeline for pushing this to the extension gallery :). I´ll keep you updated! And thanks for the update on the stop on build error :)