Upgrade to VS2019 - Githubissues

StefanKert / BuildVision

A Visual Studio extension to visualize the building process.

MIT License

261 stars 43 forks source link

Upgrade to VS2019 #69

Closed Stelzi79 closed 5 years ago

Stelzi79 commented 5 years ago

Upgrade as suggested in #68

Works in debugging and the installing the VSIX in Visual Studio 2019 works.
Testing: Unit tests pass, integration tests fail (In my Opinion something with referenced dlls is wrong. I don't have the expertise to debug this.)
Needs more testing in other versions of Visual Studio

I also changed from the deprecated package.config to the now preferred PackageReference way of referencing NuGet packages. I also updated some NuGet packages to there newest stable package.

StefanKert commented 5 years ago

Hey there! Thanks so much for your pull request! I really appreciate your help.

It seems like you accidently committed the Upgrade Files, so before merging this I´d suggest to remove them because we should be good without them as you perfectly pointet out in the .gitignore file :)

Additionaly it seems like I made a mistake in the bump_verison script so if you could do a rebase / merge from develop branch it would be amazing to have at least the CI build running.

I had no time yet to take a look at the other files, but as soon as the Upgrade-Files get removed I will take another look.

Thanks again so much for helping out!! Greatly appreciated.

Stelzi79 commented 5 years ago

I've now also rebasesed to your Develop branch for a better merge.

StefanKert commented 5 years ago

Thanks. Looks really good right now but there is stilla compilation issue. Does the current version compile locally?

Stelzi79 commented 5 years ago

screenshot_3

Yes except the IntegrationTests project. It produces also in Debug and Release a proper VSIX

Stelzi79 commented 5 years ago

Also the 3 UnitTests pass.