search

StefanKert / BuildVision

A Visual Studio extension to visualize the building process.
MIT License
261 stars 43 forks source link

Elapsed Time Continues After Build Has Completed #75

Closed yannduran closed 4 years ago

yannduran commented 5 years ago

v3.0.0.90

image

The elapsed time never stops counting

yannduran commented 5 years ago

This seems to have stopped now. Curiously, the version number remains v3.0.0.90 (weird).

But I do now end up with two sets of parentheses:

image

savehansson commented 5 years ago

I've seen this exact issue(s) too.

Steps to Reproduce:

  1. Don't know :(

After running some builds, (Ctrl+Shift+B), some with errors/warnings, some without, the elapsed time in the head doesn't stop after a build is completed. It just keeps ticking.

Workaround:

  1. Restart VS (I think, at least I can't reproduce it after my latest restart).

If I find out how to reproduce, I'll get back to you.

savehansson commented 5 years ago

I managed to reproduce it. I just canceled a build (with the Cancel button in the BuildVision head). Elapsed time continues to count. image

StefanKert commented 5 years ago

This looks pretty weird. I am currently investigating, but didn´t have this problem yet. I´ll keep you posted as soon as I have a solution.

StefanKert commented 5 years ago

Hi folks!

sorry for the delay. As mentioned in #80 this should be solved in the latest pushed version (3.0.0-preview-1.96+2cf7960452). Maybe you could give it a try and let me know if it is working for you. Thanks!

yannduran commented 4 years ago

I can confirm that this doesn't seem to be happening in build 3.0.0.104.

jzabroski commented 4 years ago

@StefanKert Just a question... what is the versioning scheme for BuildVision? I found this thread because I am on 3.0.0+e9e47924bc, but I can't infer from 3.0.0-preview-1.96+2cf7960452 whether my version is greater or less than that number. I do know I built this computer in Amazon Workspaces in March, so in theory it should've come after 3.0.0-preview-1.96+2cf7960452 ? It looks like my version is the official 3.0.0 release https://github.com/StefanKert/BuildVision/releases/tag/v3.0.0 - but it's not clear to me what "-preview-1.96+2cf7960452" refers to.

yannduran commented 4 years ago

@jzabroski if you take a look in the Extension Manager, a more user-friendly version is displayed there.

I also currently have v3.0.0+e9e47924bc installed (& this appears in the tool window tab if you have it docked).

image

In Extension Manager it shows as 3.0.0.104..

image

jzabroski commented 4 years ago

@yannduran It is still difficult to understand which one is greater. Preview builds do not go on marketplace, so I am trying to understand the lineage of releases between official releases and previews.

StefanKert commented 4 years ago

Hi folks!

sorry for the delay and thanks to @yannduran for jumping in and answering :)

@jzabroski you are definetly right. The versioning is really confusing at the moment. The idea of these versions is based on Semantic Versioning and therefore it should follow the following approach:

Major.Minor.Patch[-Prerelease]+gitHash

So the actual release is 3.0.0+e9e47924bc If a prerelease flag is added like in 3.0.0-preview-1.96+2cf7960452 it is prior the actual release. The prerelease flag is only used in versions that can be installed manually or through the various feeds.

For the future I think it makes sense to remove the git Hash from the Productversion to make things mor cleary:

3.0.0 3.0.1-preview.1 3.0.1-preview.2 3.0.1 3.1.0-preview.1 ...

jzabroski commented 4 years ago

@StefanKert Thank you. I love this tool (and the name of it), by the way. People like you, with an eye for simplicity, are force multipliers.