Removed extra formatting

toughengineer commented 5 years ago

Extra formatting causes text like this:

Build solution 'Foo' completed successfully at 1:23:45 ( (01:23))

Notice extra parentheses around elapsed time. No big deal, but it is somewhat annoying. :)

P.S. this extension is pure AWESOMENESS!

toughengineer commented 5 years ago

Even funnier if you customize string format ({0}) foo:

Build solution 'Foo' completed successfully at 1:23:45 ( (01:23) foo) foo

StefanKert commented 5 years ago

Hi @toughengineer,

CONGRATS to your first contribution to GitHub :)

first of all thank you so much for the kind words and the pull request :)

Since I am currently working on a pretty big restructering of BuildVision in #71 I think merging this is not really possible. I will try to merge #71 asap so I think we have two choices to get your fixes in (which I really want to have in :) )

You branch off from feature/asyncpackage , add your fix and send a PR to this branch and we merge it
I can bring the changes in manually but that would remove your commits from history which would also make your contributions "invisible" and IMO this is not really good.

I leave it up to you to choose whatever you prefer :)

Once again thanks for your fix and sorry for the inconvenience!

toughengineer commented 5 years ago

Hey, @StefanKert!

I don't really care about commit history, I just would like it to be fixed. :)

So if bringing changes manually is simpler, please go ahead. Otherwise I am willing to branch #71 and yada yada...

StefanKert commented 5 years ago

Sorry for the delay. I just added your changes to version 3.0.0 so the double parantheses is gone now :) thanks so much for your help!

StefanKert / BuildVision

Removed extra formatting #76

CONGRATS to your first contribution to GitHub :)