search

StefanKopieczek / gossip

SIP stack in Golang
GNU Lesser General Public License v2.1
336 stars 109 forks source link

Check for nil pointer in via header #12

Closed clintberry closed 9 years ago

clintberry commented 9 years ago

This is a fix to a nil pointer reference. I put in a default just in case.

rynorris commented 9 years ago

Looks good. =D

One small thing: Could you change the definition of port to use "port :=" instead of "var port" to match the surrounding code?

clintberry commented 9 years ago

Absolutely. We love this library. Thanks for your contributions. My friend/co-worker has been fuzzing the lib with all sorts of stress tests. https://github.com/dvyukov/go-fuzz

We found a few deadlocks and panics. I don't know if you want me to contribute back all our changes, but if you are interested, we will continue adding fixes on the weave-lab fork.

rynorris commented 9 years ago

Awesome, we were just talking about doing some fuzzing the other day!

Please do submit more pull requests. :)

If you don't mind me asking, what are you using gossip for?

clintberry commented 9 years ago

The plan is to build a distributed SIP proxy/registrar. I have a simple registrar working, but we are still a ways away from completing the distributed data store, dynamically getting data from external data stores, etc. We will be open sourcing the whole thing for all! Hopefully it will be valuable to people. We are just sick of working and scaling these old SIP systems (kamailiio, freeswitch, etc)

StefanKopieczek commented 9 years ago

Sounds exciting! Definitely interested to see how you guys get on. Do keep in touch if you have any questions, and if you get the chance to turn any more of your fixes into pull requests we'd love to take them. Great to see that you're getting some use out of gossip — we like it too, but it needs a lot more work before I'll feel satisfied with it :)