search

StefanKopieczek / gossip

SIP stack in Golang
GNU Lesser General Public License v2.1
336 stars 109 forks source link

Transaction layer does not correlate ACKs to 2xx final responses properly. #2

Open rynorris opened 9 years ago

rynorris commented 9 years ago

We do not deal with the fact that an ACK to a 2xx response has a different branch parameter, so we currently just drop them on the floor.

Need to include some cleverer matching in this case to send it to the right transaction.

rynorris commented 9 years ago

Actually, we shouldn't be matching these ACKs at all. They should be passed up to the TU as new requests. Dealing with them is the TU's problem. See RFC3261 13.3.1.4 for details.