search

StefanKopieczek / gossip

SIP stack in Golang
GNU Lesser General Public License v2.1
336 stars 109 forks source link

Display name fails to parse #26

Closed StefanKopieczek closed 7 years ago

StefanKopieczek commented 9 years ago

The parser rejects the following:

From: "John"<sip:foo@bar.com>

and

To: Jane<sip:bar@foo.com>

... However, having a space before the angle bracket should not be compulsory, per rfc 3261 20.10.

matlab2000 commented 8 years ago

I just find this bug too. as the BNF by sip spec, at last , i add firstSpace := findAnyUnescaped(addressText, c_ABNF_WS, quotes_delim, angles_delim) //add start if firstSpace==-1 && (firstAngleBracket>=1 && addressText[firstAngleBracket-1]=='"') { firstSpace=firstAngleBracket } //add end to hack it

StefanKopieczek commented 7 years ago

Fixed by @DiscoViking in 90ad88d60ab57af45bb897724eb60593440170d1