Fix bug and Add new Feature

StefanKopieczek / gossip

SIP stack in Golang

GNU Lesser General Public License v2.1

336 stars 109 forks source link

Fix bug and Add new Feature #29

Closed kuun closed 7 years ago

kuun commented 7 years ago

Fixed
- GenericHeader name is lower case
- Update Content-Length while updating message body
Feature
- Support to add header to front of header list

kuun commented 7 years ago

@StefanKopieczek Is the repo is maintained?

StefanKopieczek commented 7 years ago

Hey @kuun, yes it is :) I've been travelling for a few weeks so haven't had a chance to look at this yet. Thanks so much for the contribution though - I should be able to take a proper look tomorrow. Sorry for the long wait!

StefanKopieczek commented 7 years ago

All look good, thanks a bunch @kuun !

I debated a bit about the Content-Length header change since it's not required for UDP traffic, but it doesn't do any harm and it makes the library more usable - so I think it was the right change.

Cheers for helping out with Gossip!

kuun commented 7 years ago

Some sip appliances check 'Content-Length', if 'Content-Length' doesn't match real conent length, the request or response will be rejected.