StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.55k stars 62 forks source link

End of Windows 7 support (?) #113

Open Komprogue opened 6 months ago

Komprogue commented 6 months ago

v.2.4.10 is running without any problems, but the latest build (v.2.5.4) doesn't run at all.

explorer_jWfyaIZmxO

StefanLobbenmeier commented 6 months ago

Oh weird, not sure. We did an electron upgrade in that version, so that is the most likely culprit.

The error message is

Entry point to procedure DiscardVirtualMemory not found in DLL library KERNEL32.dll.

StefanLobbenmeier commented 6 months ago

Yeah looks like support was dropped:

Electron 23 no longer supports Windows 7/8/8.1. Electron follows the planned Chromium deprecation policy, which will deprecate Windows 7/8/8.1 , as well as Windows Server 2012 and 2012 R2 support in Chromium 109 (read more here).

https://www.electronjs.org/blog/electron-23-0#dropping-windows-7881-support

Just out of curiosity- could you also give v3 a shot? It probably does not have all the features you need yet, but would be nice to know if that still supports Windows 7

https://github.com/StefanLobbenmeier/yt-dlp-compose/releases

Komprogue commented 6 months ago

Just out of curiosity- could you also give v3 a shot? It probably does not have all the features you need yet, but would be nice to know if that still supports Windows 7

https://github.com/StefanLobbenmeier/yt-dlp-compose/releases

It doesn't run too. Have got this error message only.

explorer_WfHlQvUiC2

StefanLobbenmeier commented 6 months ago

I see, thank you for trying. Looks like the JVM that I package by default with v3 does not even list windows 7 on this page 💀 https://adoptium.net/de/supported-platforms/

I will also continue shipping with the latest JVMs, but I think I can stay compatible with Java 8 for some time, so that way you should be able to install Java 8 to run the .jar release instead. The current one needs at least Java 17, but I can change the configuration for now