StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.54k stars 61 forks source link

Downloaded files are deleted immediately (Duplicate Filename bug) and Bounce Progress bar - Windows 11 #121

Open Charlie-Ramirez-Animation-Studios-de-MX opened 5 months ago

Charlie-Ramirez-Animation-Studios-de-MX commented 5 months ago

Describe the bug While this could be considered a duplicate of bugs 105 and 85, it appears that the problem is now occurring on computers that have not experienced it before, and a bounce effect is generated in the progress bar (as if the file was deleted in chunks while writing)

I have never had a problem with avoid duplicate names being set, but it seems that the problem was triggered after Windows 11 23H2 KB5036980 on April 25. The GUI continues to show the file as a complete download but when searching for it in the folder or opening it from the GUI it returns a file not found error window (There is no temporary folder or Fragment files even if a new or empty folder or storage unit is assigned) I had not noticed the lack of files after the update date until today because the GUI always suggests everything ended correctly

To Reproduce Steps to reproduce the behavior: 1- Launch Open Video downloader Version: 2.5.4 on a Windows 11 machine with the 2024-04 Cumulative Update Preview for Windows 11 Version 23H2 for x64-based Systems (KB5036980) 2- - Set "Avoid failing to save duplicate filename" . to activated. 3- Download any video (There is no distinction between shorts or video and name/length) THE PROBLEM ONLY OCCURS WITH THE SAVE VIDEO+AUDIO SETTING. does not trigger if the download [audio only] or [video only] settings are used. (if you try to use video+audio after having downloaded both separately, the joined file is deleted instantly but both previously downloaded files are kept theoretically the mp4 video should be rewritten)

The save also fails if you already have the two separate [video/audio Only] files and you try to download as [Video+audio] with the avoid failing~ setting DISABLED

3.5- The bounce effect is easier to observe on slow networks or on large videos and download log. 4- The download logs do not seem to offer useful information and show normal progress and download completed

Expected behavior The download should not be removed when trying to merge the audio and video files (so suggests it could be a merging stage issue)

While the suggestion to disable the setting is a patch that allows reuse, it is also affected if the previously separated files are already found.

Although not the ideal solution, it might be useful to add a warning about the presence of the "Avoid failing to save duplicate filename" Bug or a post-verification step in the progress bar to check if the file has been saved or deleted, while a solution is found. Since the Download complete message suggests that everything has finished successfully despite not being the case.

(The only difficulty I find in this verification would be in the event that the separate .mp4 exists, for example, and that it is confused as the final file only because of the name.)_

Screenshots image {Video of Jumping Progress bar} -- [😄Let's omit the background song, I forgot to turn off the audio in the recording. ] https://github.com/StefanLobbenmeier/youtube-dl-gui/assets/64709446/d34e3d5b-b40a-44d7-95c1-c5b3d34cff97 Additional info (please complete the following information):

Additional context I had activated the duplicate names function for a long time (around January) because I had problems saving some songs in which the name is shared but the file is different, everything without news with it; I had even downloaded videos with audio in the period as well without any problem, but since the end of April (close to the Windows Cumulative Update) was when the videos stopped saving (I didn't realize until today because I usually trust the program it said it was completed)

Charlie-Ramirez-Animation-Studios-de-MX commented 5 months ago

UPDATE: 2024-05-15 T 18:19 UTC

Now it is also failing even if the duplicate names setting is disabled

Apparently the problem seems to be due to the handling of invalid characters in file names that are replaced by other ASCII ones in the process image It can be downloaded but it takes at least 2 attempts to save image