StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.5k stars 60 forks source link

Set Max Video Quality. #28

Open MintMain21 opened 1 year ago

MintMain21 commented 1 year ago

Is your feature request related to a problem? Please describe. When downloading Video+Audio, we're given the option between only "Best or Worst". Once a video is queued, we're given the option to lower the video quality, but there's no way to ensure that the queued video defaults to a preferred quality. So when downloading videos available in 4K, I have to remind myself to lower the quality to 1030 P in order to ensure the video file doesn't exceed 1 GB of storage.

Describe the solution you'd like There should be a way to set a max video quality (ala-1030 P) for videos that may default to a higher than desired video quality. YT-DLP offers this with the commands such as "yt-dlp -S "res:1030"", "yt-dlp -S "height:1030"", and "yt-dlp -S "res:720,fps"".

Describe alternatives you've considered If one were to use YT-DLP raw in a terminal, one could set up a config file with this exact preference. If this app has a similar config file that will not conflict with the GUI's operations, then it is beyond my awareness, and ideally should be incorporated into the settings like most other YT-DLP options are.

Additional context On the hardware that I use this app on, I can afford to store videos with quality as high as 1030, however people using the app on lesser hardware would appreciate being able to download videos no higher than 720, 480, or even 360 p.

StefanLobbenmeier commented 1 year ago

one could set up a config file with this exact preference

as in a config in your home folder? I think we should support that.

Unfortunately right now, open video downloader is passing in an option to ignore the config (--ignore-config), so that is why it does not work yet. Not sure what the reason for that decision was to include that option, but we could for example make this configurable if such the config is ignored or not.