search

StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.43k stars 57 forks source link

On Kubuntu 22.04.3, Open-Video-Downloader-2.5.2.AppImage does not run. #74

Closed SnowballV closed 1 year ago

SnowballV commented 1 year ago

Describe the bug On Kubuntu 22.04.3, Open-Video-Downloader-2.5.2.AppImage does not run.

To Reproduce Steps to reproduce the behavior:

  1. Download and save Open-Video-Downloader-2.5.2.AppImage;
  2. Double click the saved Open-Video-Downloader-2.5.2.AppImage;
  3. 'What do you wish to do with this file?' Choose 'Execute';
  4. Confirm to start the program Open-Video-Downloader-2.5.2.AppImage, by selecting 'Continue' (thus setting it as executable);
  5. Open-Video-Downloader-2.5.2.AppImage does not start.

Expected behavior I would expect Open-Video-Downloader-2.5.2.AppImage to run on Kubuntu 22.04.3, just like Open-Video-Downloader-2.4.10.AppImage does.

Additional info (please complete the following information):

StefanLobbenmeier commented 1 year ago

Oh weird. Can you also try version 2.5.0?

StefanLobbenmeier commented 1 year ago

https://github.com/StefanLobbenmeier/youtube-dl-gui/releases/tag/v2.5.0

Aiden-Shannon commented 1 year ago

Exactly the same issue with 2.5.2 for Pop!_OS 22.04. Also tried version 2.5.0 same issue. 2.4.10 Works perfectly.

StefanLobbenmeier commented 1 year ago

I see, thanks for testing. Then this is probably related to the Wayland detection.

Maybe @Cl00e9ment can help debug this?

for now can you try to find out if you are using Wayland? https://unix.stackexchange.com/questions/202891/how-to-know-whether-wayland-or-x11-is-being-used

SnowballV commented 1 year ago

As Aiden-Shannon - Same issue with Open-Video-Downloader-2.5.0.AppImage as with Open-Video-Downloader-2.5.2.AppImage. It does not run, on Kubuntu 22.04.3.

And I am not using Wayland, but X11.

Also, I took a look at Kubuntu/Plasma System Monitor. Even though Open-Video-Downloader-2.5.0.AppImage and Open-Video-Downloader-2.5.2.AppImage won't open, several related processes stay in memory:

For 2.5.0.AppImage: 3 instances of open-video-down Open-Video-Downloader-2.5.0.AppImage open-video-downloader.bin--no-sandbox--ozone-platform-hint=auto open-video-downloader.bin--type=zygote--no-sandbox open-video-downloader.bin--type=zygote--no-zygote-sandbox--no-sandbox

2.5.2.AppImage: 3 instances of open-video-down Open-Video-Downloader-2.5.2.AppImage open-video-downloader.bin--no-sandbox--ozone-platform-hint=auto open-video-downloader.bin--type=zygote--no-sandbox open-video-downloader.bin--type=zygote--no-zygote-sandbox--no-sandbox

Perhaps even more processes, but nothing that is clearly relatable to Open Video Downloader, for me. I will reboot, to make sure memory is cleared.

Cl00e9ment commented 1 year ago

It's probably an issue related to the Electron version bump. I don't see how the Wayland detection could be related. I'll test that later this day.

Cl00e9ment commented 1 year ago

Can reproduce on my environment (GNOME + Wayland). Running via npm run start works fine, but running the built AppImage doesn't.

The culprit is mkdirp. Downgrading it to the old version 1.0.4 fixes the issue. I'll see if there is a clean way to fix that and will make a PR.

Cl00e9ment commented 1 year ago

Seems like an issue with mkdirp. I downgraded it to a not so old version (see #75).

StefanLobbenmeier commented 1 year ago

Should built into this release: https://github.com/StefanLobbenmeier/youtube-dl-gui/releases/tag/v2.5.3

Hoping that works - on mobile right now

StefanLobbenmeier commented 1 year ago

Looks like that didn’t work - will try again tonight

StefanLobbenmeier commented 1 year ago

Just ran the release again, that worked. @SnowballV can you confirm that fixes it for you? I do not have a Linux machine to test yet.

SnowballV commented 1 year ago

@StefanLobbenmeier, Yes, I can confirm that it fixes the reported issue. Open-Video-Downloader-2.5.3.AppImage opens as expected, and after closing, the processes mentioned before do not stay in memory. However, one small glitch occurs when opening Open-Video-Downloader-2.5.3.AppImage: most times that I try, there are diagonal lines to be seen for part of a second. I don't see that when opening Open-Video-Downloader-2.4.10.AppImage.

Cl00e9ment commented 1 year ago

However, one small glitch occurs when opening Open-Video-Downloader-2.5.3.AppImage: most times that I try, there are diagonal lines to be seen for part of a second.

Probably because it's now running natively under Wayland (Wayland support is still experimental in Chromium). The problem is that when running with the compatibility layer XWayland, the UI is blurry with fractional scaling. There isn't a perfect solution. If the glitch happen only for less than a second, it's not a big deal I guess.

SnowballV commented 1 year ago

If the glitch happen only for less than a second, it's not a big deal I guess.

Indeed, it's not a big deal. But I thought it was better to report it, in case it was a symptom of something you needed to know of. Good that the AppImage now runs as expected. Thanks very much.

Cl00e9ment commented 12 months ago

But I thought it was better to report it

Yes! Thank you, I was indeed not aware of this bug.