StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.57k stars 63 forks source link

Video blank when downloading a youtube clip #84

Open ElectroBytezLV opened 1 year ago

ElectroBytezLV commented 1 year ago

Describe the bug When downloading a youtube clip the video is just black with audio.

To Reproduce Steps to reproduce the behavior:

  1. create a clip on any youtube video
  2. use the clip link to try and download the clip

Expected behavior Video downloads, but the whole video is just a black screen with the audio playing.

Screenshots N/A

Additional info (please complete the following information):

Additional context Additionally, when the video "finishes" downloading, pressing on "open file" throws an error that it couldn't be found (though that happened only on a certain video, probably due to some weird title format)

StefanLobbenmeier commented 1 year ago

I am guessing this is related to https://github.com/yt-dlp/yt-dlp/issues/7824

If so, since this project is using a fairly old version of ffmpeg we will have to change the source ffmpeg is downloaded from to fix this

StefanLobbenmeier commented 1 year ago

Or alternatively if https://github.com/ffbinaries/ffbinaries-prebuilt/issues/17 is closed we will get newer versions of ffmpeg

ElectroBytezLV commented 1 year ago

I am guessing this is related to yt-dlp/yt-dlp#7824

If so, since this project is using a fairly old version of ffmpeg we will have to change the source ffmpeg is downloaded from to fix this

Whats weird, is that I tried a different yt-dlp GUI which had the latest ffmpeg version (which you could update in settings) and it did the same thing (though it did work with webp but not mp4)

StefanLobbenmeier commented 1 year ago

I see. Can you try using the ffmpeg build from https://github.com/yt-dlp/FFmpeg-Builds?

just replace your ffmpeg in the open video downloader binaries folder

StefanLobbenmeier commented 1 year ago

(See https://github.com/jely2002/youtube-dl-gui/issues/354#issuecomment-1127269708 for the paths)

ElectroBytezLV commented 1 year ago

I see. Can you try using the ffmpeg build from https://github.com/yt-dlp/FFmpeg-Builds?

just replace your ffmpeg in the open video downloader binaries folder

Do I have to use the "master" one or the "n6.0"? And only the ffmpeg.exe or the probe one as well? Bit of a late reply, sorry.

StefanLobbenmeier commented 1 year ago

All good 😄 i would try the version they link in the readme https://github.com/yt-dlp/FFmpeg-Builds#downloads

looks like that is only ffmpeg, so I would try just replacing that.

(also make sure to disable auto update to prevent it from being overridden)

ElectroBytezLV commented 1 year ago

All good 😄 i would try the version they link in the readme https://github.com/yt-dlp/FFmpeg-Builds#downloads

looks like that is only ffmpeg, so I would try just replacing that.

(also make sure to disable auto update to prevent it from being overridden)

So I downloaded the latest ffmpeg release, replaced the existing one in the binaries folder with the new one I downloaded (disabled auto updates in app settings before) and it does the same thing. If video format is set to .mp4. screen is black and just audio when trying to download a yt clip. mkv works I believe, but that format isnt supported everywhere so mp4 would be nicer to use.

StefanLobbenmeier commented 1 year ago

I see, thanks for trying though. I will let you know if I find out anything

mid-ff-play17 commented 1 year ago

All good 😄 i would try the version they link in the readme https://github.com/yt-dlp/FFmpeg-Builds#downloads

looks like that is only ffmpeg, so I would try just replacing that.

(also make sure to disable auto update to prevent it from being overridden)

Hello Stefan, which is better to use: default FFMPEG or yt-dlp build?

StefanLobbenmeier commented 1 year ago

The yt-dlp team recommends to use their version of ffmpeg, but this repo has used them from a different source (https://ffbinaries.com/).

I would probably also use the ffmpeg from yt-dlp in the future, they probably know best, but no idea

mid-ff-play17 commented 1 year ago

The yt-dlp team recommends to use their version of ffmpeg, but this repo has used them from a different source (https://ffbinaries.com/).

I would probably also use the ffmpeg from yt-dlp in the future, they probably know best, but no idea

Thank you for answer :)