search

StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.4k stars 54 forks source link

Convert artwork/cover into jpeg format. #87

Open HironoKenta opened 10 months ago

HironoKenta commented 10 months ago

It will be nice if artwork pictures were converted into jpeg format instead of png when not in jpeg format to begin with.

Alternative 1: output container selection switch case Alternative 2: an option or checkbox to let the user choice

mid-ff-play17 commented 10 months ago

It will be nice if artwork pictures were converted into jpeg format instead of png when not in jpeg format to begin with.

Alternative 1: output container selection switch case Alternative 2: an option or checkbox to let the user choice

+, support. My program download them in WEBP

StefanLobbenmeier commented 10 months ago

Currently the JSON that we get from yt-dlp contains an array of thumbnails and they have URL’s, we don’t do anything fancy here and just download the highest resolution one.

I feel like adding an image converter to this project should not really be in scope of this project.

there are tools to bulk convert images that suit your use case much better, no?

mid-ff-play17 commented 10 months ago

Currently the JSON that we get from yt-dlp contains an array of thumbnails and they have URL’s, we don’t do anything fancy here and just download the highest resolution one.

I feel like adding an image converter to this project should not really be in scope of this project.

there are tools to bulk convert images that suit your use case much better, no?

OK, thank you for answer)

HironoKenta commented 10 months ago

But don't both yt-dlp and so your app yet include a "thumbnail convertor"? [ThumbnailsConvertor] Converting thumbnail "imagefilename.webp" to png

StefanLobbenmeier commented 10 months ago

Oh in that case it should be possible to tell at-dlp the target format, let me check

StefanLobbenmeier commented 10 months ago

You are absolutely right, there is the option

--convert-thumbnails FORMAT

in that case all we have to do is add an option for this, so definitely in scope :)

mid-ff-play17 commented 10 months ago

You are absolutely right, there is the option

--convert-thumbnails FORMAT

in that case all we have to do is add an option for this, so definitely in scope :)

Thats great! Will wait for this option)

HironoKenta commented 10 months ago

btw I just noticed, enabling "save metadata" don't save thumbnail file, like mutually exclusive